-
Notifications
You must be signed in to change notification settings - Fork 32
[Feature] [e2e-infra] Support duplicate data verification (#12253) #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @wu-sheng , It would be great if you could please review it when you have a moment. This PR is ready for review and merge. All tests have passed locally, and the change is backward-compatible. |
kezhenxu94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you’ll need to expose this to the yaml so users are able to use it
|
Hi @kezhenxu94, thanks for the feedback! I'd be happy to expose this to YAML. Could you clarify the preferred integration approach? Option A:-Add a I'm leaning towards Option A for better integration with existing workflows. Would that work, or do you have a different pattern in mind? Happy to implement whichever approach fits the project best! |
|
@Navadeep0007 option A looks good to me, please go ahead, thanks! |
|
Hi @kezhenxu94, |
|
Added missing Apache License headers to the following files to fix the CI failure reported by license-eye: examples/list_verification.yaml internal/verify/config.go internal/verify/runner.go The build should now pass successfully. ✅ |
Summary
This PR adds support for verifying duplicate data in list-type checks within the e2e infrastructure framework.
Changes
internal/verify/duplicate_check.go— implementsCheckForDuplicates()utility to detect duplicate items in a list.internal/verify/duplicate_check_test.go— unit tests to validate duplicate detection logic.Behavior
The
CheckForDuplicates()function returns an error when duplicate entries are found in a given list, helping ensure data integrity during verification.Related Issue
Fixes apache/skywalking#12253
Checklist
Notes
Future improvements may integrate this utility into the existing list verification logic for automated duplicate checking during e2e validation.